Re: [DISCUSS] Removal of old hamlet package in 3.3+ or 3.4+

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Removal of old hamlet package in 3.3+ or 3.4+

Akira Ajisaka-4
Thanks Masatake for your comments.
Added the other Hadoop mailing lists to Cc.

> I'm +1 on making imcompatible change if this blocks another Java migration issues, while I don't see strong reason to hurry as I see the patch of YARN-9279.
Agreed.

-Akira

On Sun, Feb 10, 2019 at 2:00 AM Masatake Iwasaki
<[hidden email]> wrote:

>
> Thanks for working on this, Akira.
>
>  > The only usage I can see is Apache Slider, however, the
>  > functionalities of Apache Slider have been merged into YARN.
>
> Do we have mailing lists other than yarn-dev to reach downstream developers?
> It would be better to make it confident that old hamlet of Hadoop 3 is
> used nowhere.
>
> I'm +1 on making imcompatible change if this blocks another Java
> migration issues,
> while I don't see strong reason to hurry as I see the patch of YARN-9279.
>
> Masatake Iwasaki
>
> On 2/3/19 18:10, Akira Ajisaka wrote:
> > Filed https://issues.apache.org/jira/browse/YARN-9279 to remove the
> > old hamlet package.
> >
> > -Akira
> >
> > 2019年1月21日(月) 13:08 Akira Ajisaka <[hidden email]>:
> >> Hi folks,
> >>
> >> I'd like to remove the deprecated hamlet package to reduce the maintenance cost.
> >>
> >> The old hamlet package has one character '_' and it is banned in Java
> >> 9+, so HADOOP-11875 deprecated this package and created a profile in
> >> pom.xml not to compile the package when the Java version is 9+. After
> >> the deprecation, we still have to maintenance the profile (see
> >> YARN-8123 and HADOOP-16046).
> >>
> >> The only usage I can see is Apache Slider, however, the
> >> functionalities of Apache Slider have been merged into YARN. Therefore
> >> I think there are no people using Slider with Hadoop 3.1+ and we can
> >> remove the package in 3.3+.
> >>
> >> Any thoughts?
> >>
> >> Regards,
> >> Akira
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Removal of old hamlet package in 3.3+ or 3.4+

Akira Ajisaka-4
Hi folks,

Now I have a strong reason to remove the old hamlet package.

There are 1000+ javadoc warnings in the package and they fill the output of
the precommit javadoc module.
That's why the new warnings and errors are ignored and sometimes they cause
build errors.

Now I'm investigating why the precommit job ignores new javadoc
warnings/errors
in https://issues.apache.org/jira/browse/HADOOP-16802. I'd like to remove
the package to make the investigation easier.

Regards,
Akira

On Thu, Feb 14, 2019 at 3:18 PM Akira Ajisaka <[hidden email]> wrote:

> Thanks Masatake for your comments.
> Added the other Hadoop mailing lists to Cc.
>
> > I'm +1 on making imcompatible change if this blocks another Java
> migration issues, while I don't see strong reason to hurry as I see the
> patch of YARN-9279.
> Agreed.
>
> -Akira
>
> On Sun, Feb 10, 2019 at 2:00 AM Masatake Iwasaki
> <[hidden email]> wrote:
> >
> > Thanks for working on this, Akira.
> >
> >  > The only usage I can see is Apache Slider, however, the
> >  > functionalities of Apache Slider have been merged into YARN.
> >
> > Do we have mailing lists other than yarn-dev to reach downstream
> developers?
> > It would be better to make it confident that old hamlet of Hadoop 3 is
> > used nowhere.
> >
> > I'm +1 on making imcompatible change if this blocks another Java
> > migration issues,
> > while I don't see strong reason to hurry as I see the patch of YARN-9279.
> >
> > Masatake Iwasaki
> >
> > On 2/3/19 18:10, Akira Ajisaka wrote:
> > > Filed https://issues.apache.org/jira/browse/YARN-9279 to remove the
> > > old hamlet package.
> > >
> > > -Akira
> > >
> > > 2019年1月21日(月) 13:08 Akira Ajisaka <[hidden email]>:
> > >> Hi folks,
> > >>
> > >> I'd like to remove the deprecated hamlet package to reduce the
> maintenance cost.
> > >>
> > >> The old hamlet package has one character '_' and it is banned in Java
> > >> 9+, so HADOOP-11875 deprecated this package and created a profile in
> > >> pom.xml not to compile the package when the Java version is 9+. After
> > >> the deprecation, we still have to maintenance the profile (see
> > >> YARN-8123 and HADOOP-16046).
> > >>
> > >> The only usage I can see is Apache Slider, however, the
> > >> functionalities of Apache Slider have been merged into YARN. Therefore
> > >> I think there are no people using Slider with Hadoop 3.1+ and we can
> > >> remove the package in 3.3+.
> > >>
> > >> Any thoughts?
> > >>
> > >> Regards,
> > >> Akira
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Removal of old hamlet package in 3.3+ or 3.4+

Masatake Iwasaki
I'm basically +1 on removing the package.
The patch of YARN-9279 is still applicable to trunk.

If we are still unable to remove the package due to downstream projects,
another option could be always excluding the hamlet package from javadoc
build
as done in java9 profile only now?

           <plugin>
<artifactId>maven-javadoc-plugin</artifactId>
             <configuration>
<excludePackageNames>org.apache.hadoop.yarn.webapp.hamlet</excludePackageNames>
             </configuration>
           </plugin>

On 2020/01/15 13:36, Akira Ajisaka wrote:

> Hi folks,
>
> Now I have a strong reason to remove the old hamlet package.
>
> There are 1000+ javadoc warnings in the package and they fill the output of
> the precommit javadoc module.
> That's why the new warnings and errors are ignored and sometimes they cause
> build errors.
>
> Now I'm investigating why the precommit job ignores new javadoc
> warnings/errors
> in https://issues.apache.org/jira/browse/HADOOP-16802. I'd like to remove
> the package to make the investigation easier.
>
> Regards,
> Akira
>
> On Thu, Feb 14, 2019 at 3:18 PM Akira Ajisaka <[hidden email]> wrote:
>
>> Thanks Masatake for your comments.
>> Added the other Hadoop mailing lists to Cc.
>>
>>> I'm +1 on making imcompatible change if this blocks another Java
>> migration issues, while I don't see strong reason to hurry as I see the
>> patch of YARN-9279.
>> Agreed.
>>
>> -Akira
>>
>> On Sun, Feb 10, 2019 at 2:00 AM Masatake Iwasaki
>> <[hidden email]> wrote:
>>> Thanks for working on this, Akira.
>>>
>>>   > The only usage I can see is Apache Slider, however, the
>>>   > functionalities of Apache Slider have been merged into YARN.
>>>
>>> Do we have mailing lists other than yarn-dev to reach downstream
>> developers?
>>> It would be better to make it confident that old hamlet of Hadoop 3 is
>>> used nowhere.
>>>
>>> I'm +1 on making imcompatible change if this blocks another Java
>>> migration issues,
>>> while I don't see strong reason to hurry as I see the patch of YARN-9279.
>>>
>>> Masatake Iwasaki
>>>
>>> On 2/3/19 18:10, Akira Ajisaka wrote:
>>>> Filed https://issues.apache.org/jira/browse/YARN-9279 to remove the
>>>> old hamlet package.
>>>>
>>>> -Akira
>>>>
>>>> 2019年1月21日(月) 13:08 Akira Ajisaka <[hidden email]>:
>>>>> Hi folks,
>>>>>
>>>>> I'd like to remove the deprecated hamlet package to reduce the
>> maintenance cost.
>>>>> The old hamlet package has one character '_' and it is banned in Java
>>>>> 9+, so HADOOP-11875 deprecated this package and created a profile in
>>>>> pom.xml not to compile the package when the Java version is 9+. After
>>>>> the deprecation, we still have to maintenance the profile (see
>>>>> YARN-8123 and HADOOP-16046).
>>>>>
>>>>> The only usage I can see is Apache Slider, however, the
>>>>> functionalities of Apache Slider have been merged into YARN. Therefore
>>>>> I think there are no people using Slider with Hadoop 3.1+ and we can
>>>>> remove the package in 3.3+.
>>>>>
>>>>> Any thoughts?
>>>>>
>>>>> Regards,
>>>>> Akira
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]